Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
Dwoo
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Common
Dwoo
Commits
71c1d67c
Commit
71c1d67c
authored
Jul 17, 2010
by
Jordi Boggiano
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes #65: Reverting r290, users should implement __isset() properly
parent
713444fd
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
1 deletion
+5
-1
CHANGELOG
CHANGELOG
+4
-0
Core.php
lib/Dwoo/Core.php
+1
-1
No files found.
CHANGELOG
View file @
71c1d67c
...
...
@@ -4,6 +4,10 @@
and
count
(
just
a
helper
that
counts
anything
).
It
won
't affect you
unless you built some plugin depending on isArray, in which case you
should check all works fine still
! BC Break: The fix for objects implemented __get but not __isset that was
applied in 1.1.1 was causing problems for people implementing it
correctly, therefore it had to be reverted. If you are affected you must
implement __isset() properly
! BC Break: Dwoo_Core::get now returns a new Dwoo_Core instance if it'
s
evaluating
a
template
already
,
this
only
affects
you
if
you
built
your
own
include
-
like
plugin
,
see
the
changes
to
include
plugin
in
revision
...
...
lib/Dwoo/Core.php
View file @
71c1d67c
...
...
@@ -1258,7 +1258,7 @@ class Dwoo_Core
return
null
;
}
}
else
{
if
(
is_object
(
$data
)
&&
(
$safeRead
===
false
||
isset
(
$data
->
$m
[
2
][
$k
])
||
is_callable
(
array
(
$data
,
'__get'
))
))
{
if
(
is_object
(
$data
)
&&
(
$safeRead
===
false
||
isset
(
$data
->
$m
[
2
][
$k
])))
{
$data
=
$data
->
$m
[
2
][
$k
];
}
else
{
return
null
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment