Commit 71c1d67c by Jordi Boggiano

Fixes #65: Reverting r290, users should implement __isset() properly

parent 713444fd
...@@ -4,6 +4,10 @@ ...@@ -4,6 +4,10 @@
and count (just a helper that counts anything). It won't affect you and count (just a helper that counts anything). It won't affect you
unless you built some plugin depending on isArray, in which case you unless you built some plugin depending on isArray, in which case you
should check all works fine still should check all works fine still
! BC Break: The fix for objects implemented __get but not __isset that was
applied in 1.1.1 was causing problems for people implementing it
correctly, therefore it had to be reverted. If you are affected you must
implement __isset() properly
! BC Break: Dwoo_Core::get now returns a new Dwoo_Core instance if it's ! BC Break: Dwoo_Core::get now returns a new Dwoo_Core instance if it's
evaluating a template already, this only affects you if you built your evaluating a template already, this only affects you if you built your
own include-like plugin, see the changes to include plugin in revision own include-like plugin, see the changes to include plugin in revision
......
...@@ -1258,7 +1258,7 @@ class Dwoo_Core ...@@ -1258,7 +1258,7 @@ class Dwoo_Core
return null; return null;
} }
} else { } else {
if (is_object($data) && ($safeRead === false || isset($data->$m[2][$k]) || is_callable(array($data, '__get')))) { if (is_object($data) && ($safeRead === false || isset($data->$m[2][$k]))) {
$data = $data->$m[2][$k]; $data = $data->$m[2][$k];
} else { } else {
return null; return null;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment